py3: remove six from requirements
#4536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: As of #4510, we don’t need `six`, so we can remove it from the Pip package requirements. Part of #4488. Test Plan: Running `:extract_pip_package` and installing it into a virtualenv still installs `six` as a transitive dep, so this is actually no functional change for now. Maybe one day. wchargin-branch: py3-norequire-six wchargin-source: c7a05be7531841c2c998bf06ceb3501c2a80f16a
Contributor
Author
|
(Oops, forgot to request review.) |
nfelt
approved these changes
Jan 14, 2021
Contributor
nfelt
left a comment
nfelt
left a comment
There was a problem hiding this comment.
You could say six has been... deep-sixed 🥁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As of #4510, we don’t need
six, so we can remove it from the Pippackage requirements.
Part of #4488.
Test Plan:
Running
:extract_pip_packageand installing it into a virtualenv stillinstalls
sixas a transitive dep, so this is actually no functionalchange for now. Maybe one day.
wchargin-branch: py3-norequire-six