rust: implement ListPlugins for blobs
#4546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The `Commit` structure now has a `blob_sequences` store in addition to its `scalars` store. For now, we only actually load run graphs into memory (since it’s trivial, and everything else is merely easy). Test Plan: Unit tests included. There are no user-facing changes to the RPC layer. Loading an MNIST dataset with scalars, graphs, and images no longer prints warnings about `graph_def`s, and still serves scalars properly. wchargin-branch: rust-load-graphs wchargin-source: a16be4c845d05f74034e5a038439c210d8b3e937
Summary: The existing `ListPlugins` RPC now explores blob sequence time series for plugin names, in addition to scalar time series. This patch also expands the `commit::test_data` builders to support blob sequences. Test Plan: Unit tests updated. As an end-to-end test, pointing TensorBoard at a directory with scalars and graphs now causes the graphs dashboard to appear active in addition to the scalars dashboard. The dashboard doesn’t yet work, since `ListBlobSequences`, et al. aren’t implemented. wchargin-branch: rust-listplugins-blobs wchargin-source: fbab637da1881c51f9b5559abb97141b58fe0387
wchargin-branch: rust-listplugins-blobs wchargin-source: 366fe5ecc221b2101e0190146b1d9e4e33de305e
wchargin-branch: rust-load-graphs wchargin-source: 33d56123cfe3da7c79b5a6bbfa9951159038ebcb
wchargin-branch: rust-listplugins-blobs wchargin-source: 1d0bdb4ae5370b1b94c30e81ec333c5e3ca1e0eb
psybuzz
approved these changes
Jan 15, 2021
wchargin-branch: rust-listplugins-blobs wchargin-source: 6f6f9b22500fb277be51df26f64ae80523eeb69c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The existing
ListPluginsRPC now explores blob sequence time seriesfor plugin names, in addition to scalar time series. This patch also
expands the
commit::test_databuilders to support blob sequences.Test Plan:
Unit tests updated. As an end-to-end test, pointing TensorBoard at a
directory with scalars and graphs now causes the graphs dashboard to
appear active in addition to the scalars dashboard. The dashboard
doesn’t yet work, since
ListBlobSequences, et al. aren’t implemented.wchargin-branch: rust-listplugins-blobs