metrics: fix wall time rendering #4552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The TensorBoard backend sends wall times in floating-point seconds since epoch, and the scalars dashboard interprets them accordingly. But the time series dashboard was interpreting them as milliseconds since epoch, causing recent dates to be rendered around January 1970. This patch fixes the frontend to multiply by 1000, as the scalars dashboard does. This bug also affected relative times, which were shown compressed by a factor of 1000 on the horizontal axis (but not in the tooltips). This bug did not affect GPU line charts. Fixes #4541. Test Plan: ![Comparison screenshot of two chart views in the time series dashboard. Before: the wall time spans a single second, labeled “06:16:46 PM January 18, 1970”. After: the wall time starts on “04:31 PM July 17, 2019” and ends at “04:35 PM July 17, 2019”.][ss] [ss]: https://user-images.githubusercontent.com/4317806/104562449-3a695300-55fd-11eb-81e9-15377175dfa4.png wchargin-branch: metrics-date-milliseconds wchargin-source: 4035248298114f38528aa16e54a1a459c39d4dc9
stephanwlee
approved these changes
Jan 14, 2021
psybuzz
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The TensorBoard backend sends wall times in floating-point seconds since
epoch, and the scalars dashboard interprets them accordingly. But the
time series dashboard was interpreting them as milliseconds since epoch,
causing recent dates to be rendered around January 1970. This patch
fixes the frontend to multiply by 1000, as the scalars dashboard does.
This bug also affected relative times, which were shown compressed by a
factor of 1000 on the horizontal axis (but not in the tooltips). This
bug did not affect GPU line charts.
Fixes #4541.
Test Plan:
wchargin-branch: metrics-date-milliseconds