rust: support tagged run metadata graphs #4568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: We now support TF 1.x images, TF 2.x images, and any tensors that have an explicit blob sequence data class. Test Plan: Unit tests included. As an end-to-end test, images now appear in TensorBoard with `--load_fast`, in both the images and time series dashboards. wchargin-branch: rust-images-generic-blobs wchargin-source: 614b7b48a326e3303af05b5790da402ba5f72af3
Summary: For some data types, data-compat conversions of _values_ depend on the time series _metadata_. For instance, we need to adjust the shapes of audio tensors to remove labels, and we need to update graph sub-plugins (Keras models, etc.) to convert scalars to tensors. This patch updates the `EventValue::into_blob_sequence` interface to require a reference to the initial summary metadata so that we can add support for such data types. It’s not yet used. Test Plan: Existing unit tests suffice; for an end-to-end test the graphs and images plugins still work. wchargin-branch: rust-blob-sequence-metadata wchargin-source: 318204dbc3eaedf339f13b4d166b9b823248a6af
Summary: We now support TF 1.x and TF 2.x audio summaries. This includes TF 2.x audio summaries with labels; the labels will be stripped. This means that the audio dashboard now works under `--load_fast`. Test Plan: Unit tests should suffice. As an end-to-end test, checked the audio dashboard against TF 2.x audio summaries both with and without labels (i.e., of shape `[k, 2]` and of shape `[k]`), and against [TF 1.x data]. [TF 1.x data]: https://gist.github.com/wchargin/d9c415fb609119824919de8391d0b8c4 wchargin-branch: rust-audio wchargin-source: 16ec21cd82fb0145b816d2d2b3e01859d4a54511
Summary: This patch adds support for TF 1.x `tagged_run_metadata` events. Because this is a new top-level event type, the change extends into the `run` module as well as `data_compat`, but the changed surface area is still rather small. Test Plan: The graphs demo added in #4469 includes tagged run metadata graphs. They now appear in the graphs dashboard with `--load_fast`, and include compute time information. wchargin-branch: rust-tagged-run-metadata wchargin-source: e8ed2e7af25aba1206bccf77218edaf231b1c858
wchargin
added
plugin:graph
core:rustboard
stephanwlee
approved these changes
Jan 19, 2021
wchargin-branch: rust-tagged-run-metadata wchargin-source: e15fce57af63333f86dcc6e530466a866c90b76d # Conflicts: # tensorboard/data/server/data_compat.rs
wchargin-branch: rust-tagged-run-metadata wchargin-source: e15fce57af63333f86dcc6e530466a866c90b76d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This patch adds support for TF 1.x
tagged_run_metadataevents. Becausethis is a new top-level event type, the change extends into the
runmodule as well as
data_compat, but the changed surface area is stillrather small.
Test Plan:
The graphs demo added in #4469 includes tagged run metadata graphs. They
now appear in the graphs dashboard with
--load_fast, and includecompute time information.
wchargin-branch: rust-tagged-run-metadata