infra: implement dev assets #4589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, dev assets are significantly different than prod one. To enumerate the differences: - Angular application now loads in dev mode allowing ngrx to print diagnostic information on console - No longer vulcanize. Previously, we vulcanized to inline CSS, HTML, and resources and combined JavaScript into a single source. With this change, we no longer inline/concat sources and load them separately. - this breaks roboto.html loading as it internally uses rel="import" but we intend to get rid of it to remove dependency on tensorboard_html_binary which pulls in Java dependency.
nfelt
approved these changes
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, dev assets are significantly different than prod one.
To enumerate the differences:
diagnostic information on console
and resources and combined JavaScript into a single source. With this
change, we no longer inline/concat sources and load them separately.
but we intend to get rid of it to remove dependency on
tensorboard_html_binary which pulls in Java dependency.
temporary: this change contains PR #4588