rust: add crossbeam dependency
#4627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The [`crossbeam`] crate provides utilities for concurrent programming. It’s best known for its [scoped threads, which enable safe sharing of local variables][2p], often considered too dangerous in C++. For loading runs concurrently, we’ll used scoped threads and also concurrent queues. [2p]: https://matklad.github.io/2020/07/15/two-beautiful-programs.html [`crossbeam`]: https://crates.io/crates/crossbeam Test Plan: It builds: `bazel build //third_party/rust:crossbeam`. wchargin-branch: rust-dep-crossbeam wchargin-source: 4903950564d6e54b4a057d87ecac8f0c8d5d590f
wchargin
added
dependencies
stephanwlee
approved these changes
Jan 29, 2021
Contributor
stephanwlee
left a comment
stephanwlee
left a comment
There was a problem hiding this comment.
Where do we intend to use the concurrency?
Contributor
Author
|
For loading runs concurrently within a logdir (i.e., every run loads |
Contributor
Author
|
If curious, you can see the draft implementation of concurrent run |
wchargin
added a commit
that referenced
this pull request
Jan 30, 2021
Summary: The [`rayon`] crate provides easy data parallelism: change `iter()` to `par_iter()` and you’re off to the races—but not the data races, which are prevented at compile time. We can use it to load runs concurrently. [`rayon`]: https://crates.io/crates/rayon Test Plan: It builds: `bazel build //third_party/rust:rayon`. wchargin-branch: rust-dep-rayon wchargin-source: 743dee6a68571fd8849ea4dfd240169bcfbe1feb
wchargin
added a commit
that referenced
this pull request
Feb 2, 2021
Summary: The [`rayon`] crate provides easy data parallelism: change `iter()` to `par_iter()` and you’re off to the races—but not the data races, which are prevented at compile time. We can use it to load runs concurrently. [`rayon`]: https://crates.io/crates/rayon Test Plan: It builds: `bazel build //third_party/rust:rayon`. wchargin-branch: rust-dep-rayon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The
crossbeamcrate provides utilities for concurrent programming.It’s best known for its scoped threads, which enable safe sharing of
local variables, often considered too dangerous in C++. For loading
runs concurrently, we’ll used scoped threads and also concurrent queues.
Test Plan:
It builds:
bazel build //third_party/rust:crossbeam.wchargin-branch: rust-dep-crossbeam