rust: add bytes dependency
#4671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The [`bytes`] crate provides facilitates zero-copy network programming with the `Bytes` struct, which is a kind of “`Arc<[u8]>` on steroids” that can be sliced and passed around with shared ownership. Other parts of our stack already use `Bytes` (notably, `tonic`, `reqwest`, and `prost`), so by using it ourselves we can remove some unnecessary clones, as discussed in [review on #4646]. Since this already exists as a transitive dep, this patch just exposes it for direct use by our code. [`bytes`]: https://crates.io/crates/bytes [review on #4646]: #4646 (comment) Test Plan: It builds: `bazel build //tensorboard/data/server/cargo:bytes`. wchargin-branch: rust-dep-bytes wchargin-source: 13445ec2b94489c55c33e0c3eea775d9e06aa683
wchargin
added
dependencies
psybuzz
approved these changes
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The
bytescrate provides facilitates zero-copy network programmingwith the
Bytesstruct, which is a kind of “Arc<[u8]>on steroids”that can be sliced and passed around with shared ownership. Other parts
of our stack already use
Bytes(notably,tonic,reqwest, andprost), so by using it ourselves we can remove some unnecessaryclones, as discussed in review on #4646. Since this already exists as
a transitive dep, this patch just exposes it for direct use by our code.
Test Plan:
It builds:
bazel build //tensorboard/data/server/cargo:bytes.wchargin-branch: rust-dep-bytes