pip: depend on tensorboard-data-server
#4676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The `tensorboard` Pip package now depends on `tensorboard-data-server`. Thus, users of standard TensorBoard may now pass `--load_fast` on supported platforms. Users can still install TensorBoard even on a platform that does not support the data server, because the data server package includes a universal binary (`*-py3-none-any.whl`). This package can always be installed, but does not implement any functionality, and so attempting to use it with `--load_fast` will fail at runtime. For now, we pin to exactly the v0.3.x minor series so that we can more comfortably make breaking changes to the data server. Test Plan: Run `//tensorboard/pip_package:extract_pip_package` and install the resulting wheel into a fresh virtualenv. Note that both TensorBoard and the data server are installed, and that launching TensorBoard with `--load_fast --verbosity 0` (a) logs that the data server is being launched “from Python package” and (b) loads fast. wchargin-branch: pip-data-server-dep wchargin-source: a8de7f873b76a813e1c54a65d7f7d4f388c445ea
mdraw
added a commit
to mdraw/staged-recipes
that referenced
this pull request
Apr 25, 2021
Required for conda-forge/tensorboard-feedstock#51 See tensorflow/tensorboard#4676 This is only the noarch dummy package, which should be used as a fallback. As the next step, we should provide the actual platform-specific packages where possible: namely mac x86_64 and linux x86_64.
mdraw
added a commit
to mdraw/staged-recipes
that referenced
this pull request
Apr 25, 2021
Required for conda-forge/tensorboard-feedstock#51 See tensorflow/tensorboard#4676 This is only the noarch dummy package, which should be used as a fallback. As the next step, we should provide the actual platform-specific packages where possible: namely mac x86_64 and linux x86_64.
12 tasks
mdraw
added a commit
to mdraw/staged-recipes
that referenced
this pull request
May 3, 2021
Required for conda-forge/tensorboard-feedstock#51 See tensorflow/tensorboard#4676 This is only the noarch dummy package, which should be used as a fallback. As the next step, we should provide the actual platform-specific packages where possible: namely mac x86_64 and linux x86_64.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The
tensorboardPip package now depends ontensorboard-data-server.Thus, users of standard TensorBoard may now pass
--load_fastonsupported platforms. Users can still install TensorBoard even on a
platform that does not support the data server, because the data server
package includes a universal binary (
*-py3-none-any.whl). This packagecan always be installed, but does not implement any functionality, and
so attempting to use it with
--load_fastwill fail at runtime.For now, we pin to exactly the v0.3.x minor series so that we can more
comfortably make breaking changes to the data server.
Test Plan:
Run
//tensorboard/pip_package:extract_pip_packageand install theresulting wheel into a fresh virtualenv. Note that both TensorBoard and
the data server are installed, and that launching TensorBoard with
--load_fast --verbosity 0(a) logs that the data server is beinglaunched “from Python package” and (b) loads fast.
wchargin-branch: pip-data-server-dep