rust: add tensors to Commit and CommitBuilder #4710
Conversation
wchargin
left a comment
wchargin
left a comment
There was a problem hiding this comment.
although it's not terribly ergonomic to manipulate in Rust since we lack Numpy and the
tf.make_tensor_proto()andtf.make_ndarray()conversion methods
True. I think that we’ll be okay. The most complex thing we need to do
is histogram datacompat, where you have to futz with a [k, 3] matrix,
but it’s still not that bad imho.
tensorboard/data/server/commit.rs
Outdated
| metadata: Option<Box<pb::SummaryMetadata>>, | ||
| /// Tensor evaluation function, called for each point in the series. | ||
| /// | ||
| /// By default, this maps every step to the empty float32 tensor. |
There was a problem hiding this comment.
Is this actually a valid tensor? Its shape is not specified, and if it’s
inferred to be an empty list of dimensions, then it has the wrong number
of elements (0 instead of 1).
For hparams, we use a length-0 float vector instead. Might that be
more appropriate?
There was a problem hiding this comment.
Oops, you're right, thanks. Changed to use length-0 float vector.
| } | ||
|
|
||
| /// Constructs a scalar time series from the state of this builder. | ||
| /// Constructs a blob sequence time series from the state of this builder. |
2 participants
Partial work towards rustboard tensors support (subtask of #4422).
This just adds a
tensorsfield toRunDatainsideCommit. We usepb::TensorProtoas the value type since that's what we will end up reading off disk and sending over the wire, although it's not terribly ergonomic to manipulate in Rust since we lack Numpy and thetf.make_tensor_proto()andtf.make_ndarray()conversion methods. (I looked briefly atndarraywhich seems nice but probably overkill at this point? We can see if we end up needing to do enough tensor manipulation to make it worthwhile.)That in and of itself is a one-line change, but we also extend
CommitBuilderto support constructing commits that contain tensor data. The code there is borrowed from a combination of the scalars and blobsCommitBuilderlogic.