mesh: add generic data support #4775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This patch replaces the multiplexer code in the custom scalars plugin with data provider code. It is not gated behind a flag. We treat the layout protos as tensors, since they are of scalar shape and are expected to be small. A case could be made for representing them as blob sequences with a datacompat shape conversion, but this is simpler and the plugin doesn’t get a ton of use. Test Plan: The dashboard still works with the standard demo data, both with and without `--load_fast`. wchargin-branch: custom-scalars-generic wchargin-source: 91001190a543e99ba73c407df3bc801d81eaa2cf
Summary: This patch replaces the multiplexer code in the mesh plugin with data provider code. It is not gated behind a flag. We treat all mesh data as tensors, since that’s most expedient at this time and the local data providers (multiplexer and RustBoard) don’t actually have any size constraints. See also discussion in #4734. Test Plan: The dashboard still works with the standard demo data, both with and without `--load_fast`. wchargin-branch: mesh-generic wchargin-source: 2a995b31efea5c58dee9d05fc7e66bbdb833a32e
psybuzz
approved these changes
Mar 15, 2021
wchargin-branch: mesh-generic wchargin-source: 75e006cc59401e05b0aa2b4ec49536ccc9f0aa9e
wchargin-branch: mesh-generic wchargin-source: 75e006cc59401e05b0aa2b4ec49536ccc9f0aa9e
wchargin
changed the base branch from
wchargin-custom-scalars-generic
to
master
wchargin-branch: mesh-generic wchargin-source: 75e006cc59401e05b0aa2b4ec49536ccc9f0aa9e
Contributor
Author
|
(I’ve rotated this below #4774, since that PR is still awaiting review |
wchargin-branch: mesh-generic wchargin-source: 75e006cc59401e05b0aa2b4ec49536ccc9f0aa9e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This patch replaces the multiplexer code in the mesh plugin with data
provider code. It is not gated behind a flag.
We treat all mesh data as tensors, since that’s most expedient at this
time and the local data providers (multiplexer and RustBoard) don’t
actually have any size constraints. See also discussion in #4734.
Test Plan:
The dashboard still works with the standard demo data, both with and
without
--load_fast=true.wchargin-branch: mesh-generic