core: re-enable CorePluginTest and consolidate test cases #4878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-enables the test cases that were previously under
CorePluginTestBase, which wasn't actually being executed - it used to be a common base class in between two subclasses that actually weretf.test.TestCaseinstances, but these subclasses were removed in #3539 without converting the parent class into aTestCasein its own right.In addition, I've refactored the test cases to consolidate most of them into a single
CorePluginTestclass for simplicity, since they have a lot of common functionality and IMO they were just making it harder to understand where to add a new test method. See individual commits for each consolidation step that was made.