Skip to content

Fix --one_shot for remote file system. #4909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bileschi merged 3 commits into from
Apr 29, 2021
Merged

Fix --one_shot for remote file system. #4909

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd1dbb7
Fix `--one_shot` for remote file system.
bileschi Apr 26, 2021
4fc5b49
different tf
bileschi Apr 26, 2021
254701b
add build dep on compat:tensorflow
bileschi Apr 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tensorboard/uploader/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ py_library(
"//tensorboard:expect_absl_logging_installed",
"//tensorboard:expect_grpc_installed",
"//tensorboard:program",
"//tensorboard/compat:tensorflow",
"//tensorboard/plugins:base_plugin",
"//tensorboard/uploader/proto:protos_all_py_pb2_grpc",
],
Expand Down
3 changes: 2 additions & 1 deletion tensorboard/uploader/uploader_subcommand.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@

from absl import logging
import grpc
from tensorboard.compat import tf
Copy link
Contributor

@nfelt nfelt Apr 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a BUILD dep for "//tensorboard/compat:tensorflow"


from tensorboard.uploader.proto import experiment_pb2
from tensorboard.uploader.proto import export_service_pb2_grpc
Expand Down Expand Up @@ -414,7 +415,7 @@ def execute(self, server_info, channel):
verbosity=self.verbosity,
one_shot=self.one_shot,
)
if self.one_shot and not os.path.isdir(self.logdir):
if self.one_shot and not tf.io.gfile.isdir(self.logdir):
print("%s: No such directory." % self.logdir)
print(
"User specified `one_shot` mode with an unavailable "
Expand Down