Skip to content

timeseries: keep runs table header sticky #5024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephanwlee merged 1 commit into from
May 27, 2021
Merged

timeseries: keep runs table header sticky #5024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions tensorboard/webapp/runs/views/runs_table/runs_table_component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,16 @@ $_border-color: #0000001f;
.header {
color: mat-color($tb-foreground, text);
white-space: nowrap;

// Allows table header to remain sticky to the scrollable container.
[role='columnheader'] {
background-color: mat-color($tb-background, background);
position: sticky;
top: 0;
// Unlike <thead><tr>, we need to manually "lift" the elements up so it
// masks table rows underneath.
z-index: 1;
}
}

[role='row'] {
Expand Down
11 changes: 9 additions & 2 deletions tensorboard/webapp/theme/_tb_theme.template.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,21 @@ $tb-foreground: map_merge(
)
);

$tb-background: map_merge(
$mat-light-theme-background,
(
// Default is `map.get($grey-palette, 50)`.
background: #fff
)
);

$tb-theme: map_merge(
$tb-theme,
(
background: $tb-background,
foreground: $tb-foreground,
)
);

$tb-background: map-get($tb-theme, background);

// Include all theme-styles for the components based on the current theme.
@include angular-material-theme($tb-theme);