infra: update officially supported Python version #5071
Conversation
Currently, `setup.py` was very out of date and claimed that TensorBoard supported Python which is dropped in EOY 2020. This updates the list of supported Python to match that of TensorFlow's.
nfelt
left a comment
nfelt
left a comment
There was a problem hiding this comment.
Currently,
setup.pywas very out of date and claimed that TensorBoard
supported Python which is dropped in EOY 2020.
...supported Python 2 which was dropped... <-- I assume you mean?
| "tf_projector_plugin/projector_binary.js", | ||
| ], | ||
| }, | ||
| # Disallow python 3.0 and 3.1 which lack a 'futures' module (see above). |
There was a problem hiding this comment.
Optional but maybe kill the futures and wheel deps that were py2-only too?
tensorboard/tensorboard/pip_package/requirements.txt
Lines 19 to 20 in b53c723
There was a problem hiding this comment.
It may be nice to re-add python_requires with python_requires=">=3.6", it will block folks with older version Python version from installing the library through pip https://packaging.python.org/guides/dropping-older-python-versions/
Yup, updated the description and will make sure the commit message contains the right message. |
stephanwlee
changed the title
3 participants
Currently,
setup.pywas very out of date and claimed that TensorBoardsupported Python 2 which is dropped in EOY 2020. This updates the list of
supported Python to match that of TensorFlow's.
https://github.com/tensorflow/tensorflow/blob/5809916f1ea8954b88da0b3c66922f4e5e5e9b47/tensorflow/tools/pip_package/setup.py#L346-L351
Fixes #5069.