Skip to content

layout: make resizer smaller #5390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephanwlee merged 2 commits into from
Oct 28, 2021
Merged

layout: make resizer smaller #5390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
045cab5
layout: make resizer smaller
stephanwlee Oct 28, 2021
25c67c4
expansion button which is different than resize bar still renders icon
stephanwlee Oct 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions tensorboard/webapp/core/views/layout_container.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,22 +30,36 @@ limitations under the License.
.expand {
@include tb-theme-foreground-prop(border-color, border);
box-sizing: border-box;
flex: 0 0 20px;
flex: 0 0;
Copy link
Contributor

@japie1235813 japie1235813 Oct 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this change anything?
the width of the expand is still depending on the width of the icon [>] (which is 19px and ~20px)

Copy link
Contributor Author

@stephanwlee stephanwlee Oct 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing that out. I forgot to add one file in my commit. I did remove the icon from the template.

Copy link
Contributor

@japie1235813 japie1235813 Oct 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked again. What I mean was expand_more_24px
It seems to me (mac, chrome) the expand element does not change with and without flex attribute;
Yet the icon seems bigger (24px) with setting width (line 35)

I want to make sure these are intended change (the expander getting wider).

Copy link
Contributor

@japie1235813 japie1235813 Oct 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean the icon is bigger (24px) without setting width of expand element (line 35)

Copy link
Contributor Author

@stephanwlee stephanwlee Oct 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, indeed you are correct. I have forgotten about the expander which is separate from the resize bar. Have put the width back on the expander.

justify-self: stretch;
}

.expand {
width: 20px;
}

.resizer {
align-items: center;
border-style: solid;
border-width: 0 1px;
border-width: 0 2px;
cursor: ew-resize;
display: flex;
justify-self: stretch;

.mat-icon {
width: 100%;
}

&:hover {
border-color: #ccc;
outline: 3px solid #ccc;
z-index: 1;

@include tb-dark-theme {
outline-color: #777;
border-color: #777;
}
}
}

.expand {
Expand Down
4 changes: 1 addition & 3 deletions tensorboard/webapp/core/views/layout_container.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,7 @@ import {MouseEventButtons} from '../../util/dom';
*ngIf="(width$ | async) > 0"
class="resizer"
(mousedown)="resizeGrabbed()"
>
<mat-icon svgIcon="drag_indicator_24px"></mat-icon>
</div>
></div>
<ng-content select="[main]"></ng-content>
`,
styleUrls: ['layout_container.css'],
Expand Down