cleanup: alphabetize argument order for FakeFlags #5544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yatbear
approved these changes
Feb 1, 2022
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
* sort FakeFlags fields in core_plugin_test.py * data_ingester_test.py: clean up FakeFlags arg order * application_test.py: sort FakeFlags args, make logdir a kwarg
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
* sort FakeFlags fields in core_plugin_test.py * data_ingester_test.py: clean up FakeFlags arg order * application_test.py: sort FakeFlags args, make logdir a kwarg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a few FakeFlag instances in our tests. We periodically have to add flags to these (for new flags that we're introducing or existing flags we're using in new places), but since the flags aren't in any particular order, it's kind of messy and hard to tell where to put the flag / whether a flag is already present.
This resolves this by just alphabetizing the flags. We also make them all keyword args (rather than special-casing
logdirto be a positional argument).This is pre-work for #5530.