Bug Fix: Updating typing surrounding feature_flag_serializer_test.ts
#5833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rileyajones
force-pushed
the
query-params-bug-test-format
branch
from
e09b9af to
6d4d532
Compare
bmd3k
approved these changes
Aug 1, 2022
Contributor
bmd3k
left a comment
bmd3k
left a comment
There was a problem hiding this comment.
Nit: Description says "change variable names" but this is more like "adjust types and change property access".
rileyajones
changed the title
feature_flag_serializer_test.ts
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
tensorflow#5833) change variable names in feature_flag_serializer_test.ts Update typing in feature_flag_serializer and dashboard_deeplink_provider
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
tensorflow#5833) change variable names in feature_flag_serializer_test.ts Update typing in feature_flag_serializer and dashboard_deeplink_provider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently TBCorp has different (and sometimes conflicting) lint rules so
feature_flag_serializer_testwas unable to be imported.While "updating" the typing there I also cleaned up some of the typing in the related files.
#5717