Skip to content

projector: Fix standalone vz_projector server. #6069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmd3k merged 2 commits into from
Nov 28, 2022
Merged

projector: Fix standalone vz_projector server. #6069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ca9fe1
Fix standalone vz_projector server.
bmd3k Nov 22, 2022
7f990bd
Fix BUILD lint.
bmd3k Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tensorboard/defs/web.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ def _tf_web_library(ctx):
)
params = struct(
label=str(ctx.label),
bind="localhost:0",
bind="localhost:6006",
Copy link
Contributor

@rileyajones rileyajones Nov 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mention in your description that the webserver can start with "random ports" but the user can also specify the port with an environment variable. In the future cleanup it would be nice to have this respect the environment variable.

Copy link
Contributor Author

@bmd3k bmd3k Nov 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may have missed that: What is the environment variable that users can specify?

Copy link
Contributor Author

@bmd3k bmd3k Nov 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline: We don't believe that we currently offer ability to set the port.

manifest=[long_path(ctx, man) for man in devserver_manifests.to_list()],
external_asset=[struct(webpath=k, path=v)
for k, v in ctx.attr.external_assets.items()])
Expand Down
4 changes: 2 additions & 2 deletions tensorboard/plugins/projector/tf_projector_plugin/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ tb_combine_html(
output_path = "/tf-projector/projector_binary.html",
deps = [
":tf_projector_plugin",
"//tensorboard/plugins/projector/vz_projector:standalone_lib",
"//tensorboard/plugins/projector/vz_projector:standalone",
],
)

Expand All @@ -34,6 +34,6 @@ tf_web_library(
path = "/tf-projector",
deps = [
"//tensorboard/components/tf_imports:roboto",
"//tensorboard/plugins/projector/vz_projector:standalone_lib",
"//tensorboard/plugins/projector/vz_projector:standalone",
],
)
16 changes: 3 additions & 13 deletions tensorboard/plugins/projector/vz_projector/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
load("//tensorboard/defs:defs.bzl", "tf_js_binary", "tf_ng_web_test_suite", "tf_ts_library")
load("//tensorboard/defs:web.bzl", "tb_combine_html", "tf_web_library")
load("//tensorboard/defs:web.bzl", "tf_web_library")

package(default_visibility = ["//tensorboard/plugins/projector:__subpackages__"])

Expand Down Expand Up @@ -112,9 +112,9 @@ genrule(
)

tf_web_library(
name = "standalone_lib",
name = "standalone",
srcs = [
"standalone_lib.html",
"standalone.html",
"standalone_projector_config.json",
":standalone_bundle.js",
],
Expand All @@ -124,16 +124,6 @@ tf_web_library(
],
)

tb_combine_html(
name = "standalone",
input_path = "/standalone_lib.html",
js_path = "/standalone.js",
output_path = "/standalone.html",
deps = [
":standalone_lib",
],
)

################# Test ##################

tf_ts_library(
Expand Down
2 changes: 1 addition & 1 deletion ...rojector/vz_projector/standalone_lib.html → ...ns/projector/vz_projector/standalone.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@

<link rel="import" href="../tf-imports/roboto.html" />

<script jscomp-ignore src="standalone_bundle.js"></script>
<script>
(function (i, s, o, g, r, a, m) {
i['GoogleAnalyticsObject'] = r;
Expand Down Expand Up @@ -72,6 +71,7 @@
</style>
</head>
<body>
<script jscomp-ignore src="standalone_bundle.js"></script>
<vz-projector-app
documentation-link="https://www.tensorflow.org/get_started/embedding_viz"
bug-report-link="https://github.com/tensorflow/tensorboard/issues"
Expand Down