keep using bazel 5 #6114
Merged
keep using bazel 5 #6114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfelt
reviewed
Dec 21, 2022
WORKSPACE
Outdated
| # Keep this version in sync with: | ||
| # * The BAZEL environment variable defined in .github/workflows/ci.yml, which is used for CI and nightly builds. | ||
| versions.check(minimum_bazel_version = "4.2.2") | ||
| versions.check(minimum_bazel_version = "4.2.2", maximum_bazel_version="4.5.0") |
Contributor
There was a problem hiding this comment.
Did you mean this to be 5.4.0? AFAIK bazel 5 was fine?
Contributor
Author
There was a problem hiding this comment.
Done
oops, good catch! thx!
nfelt
approved these changes
Dec 21, 2022
WORKSPACE
Outdated
| # Keep this version in sync with: | ||
| # * The BAZEL environment variable defined in .github/workflows/ci.yml, which is used for CI and nightly builds. | ||
| versions.check(minimum_bazel_version = "4.2.2") | ||
| versions.check(minimum_bazel_version = "4.2.2", maximum_bazel_version="5.4.0") |
Contributor
There was a problem hiding this comment.
Let's add a TODO with a tracking GH issue for Bazel 6+ support?
WORKSPACE
Outdated
|
|
||
| load("@bazel_skylib//lib:versions.bzl", "versions") | ||
|
|
||
| # Keep this version in sync with: |
Contributor
There was a problem hiding this comment.
This comment is a bit ambiguous now that there's two versions listed. Let's maybe structure it like this:
versions.check(
# Keep this version in sync ...
minimum_bazel_version = "4.2.2",
# TODO(<issue>)...
maximum_bazel_version = "5.4.0",
)
Contributor
Author
There was a problem hiding this comment.
Done
I totally overlooked the comments. Thanks for catching this!
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
* Motivation for features / changes Bazel 6.0.0 breaks the current TensorBoard build. ``` $ bazel run tensorboard ERROR: /usr/local/google/home/bdubois/.cache/bazel/_bazel_bdubois/a027bcadf80e351d5b786d7247b18b84/external/bazel_tools/platforms/BUILD:29:6: in alias rule @bazel_tools//platforms:arm: Constraints from @bazel_tools//platforms have been removed. Please use constraints from @platforms repository embedded in Bazel, or preferably declare dependency on https://github.com/bazelbuild/platforms. See bazelbuild/bazel#8622 for details. ERROR: /usr/local/google/home/bdubois/.cache/bazel/_bazel_bdubois/a027bcadf80e351d5b786d7247b18b84/external/bazel_tools/platforms/BUILD:29:6: Analysis of target '@bazel_tools//platforms:arm' failed ERROR: /usr/local/google/home/bdubois/git/tensorboard2/tensorboard/BUILD:20:10: While resolving toolchains for target //tensorboard:tensorboard: invalid registered toolchain '@go_sdk//:go_android_arm': ERROR: Analysis of target '//tensorboard:tensorboard' failed; build aborted: INFO: Elapsed time: 0.412s INFO: 0 processes. FAILED: Build did NOT complete successfully (0 packages loaded, 3 targets conf\ igured) ERROR: Build failed. Not running target ``` * Technical description of changes This PR follows the suggestion of this [comment](bazelbuild/bazel#8622 (comment)) to keep using Bazel 5 for now. * Detailed steps to verify changes work correctly (as executed by you) `bazel run tensorboard` works as before.
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
* Motivation for features / changes Bazel 6.0.0 breaks the current TensorBoard build. ``` $ bazel run tensorboard ERROR: /usr/local/google/home/bdubois/.cache/bazel/_bazel_bdubois/a027bcadf80e351d5b786d7247b18b84/external/bazel_tools/platforms/BUILD:29:6: in alias rule @bazel_tools//platforms:arm: Constraints from @bazel_tools//platforms have been removed. Please use constraints from @platforms repository embedded in Bazel, or preferably declare dependency on https://github.com/bazelbuild/platforms. See bazelbuild/bazel#8622 for details. ERROR: /usr/local/google/home/bdubois/.cache/bazel/_bazel_bdubois/a027bcadf80e351d5b786d7247b18b84/external/bazel_tools/platforms/BUILD:29:6: Analysis of target '@bazel_tools//platforms:arm' failed ERROR: /usr/local/google/home/bdubois/git/tensorboard2/tensorboard/BUILD:20:10: While resolving toolchains for target //tensorboard:tensorboard: invalid registered toolchain '@go_sdk//:go_android_arm': ERROR: Analysis of target '//tensorboard:tensorboard' failed; build aborted: INFO: Elapsed time: 0.412s INFO: 0 processes. FAILED: Build did NOT complete successfully (0 packages loaded, 3 targets conf\ igured) ERROR: Build failed. Not running target ``` * Technical description of changes This PR follows the suggestion of this [comment](bazelbuild/bazel#8622 (comment)) to keep using Bazel 5 for now. * Detailed steps to verify changes work correctly (as executed by you) `bazel run tensorboard` works as before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bazel 6.0.0 breaks the current TensorBoard build.
Technical description of changes
This PR follows the suggestion of this comment to keep using Bazel 5 for now.
Detailed steps to verify changes work correctly (as executed by you)
bazel run tensorboardworks as before.