Revert "fix: update debugger v2 test" #6133
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit faa8f57.
Contributor
|
For googlers, Before reverting, it would be best to find any discrepancies between internal tests and github builds/tests and what is causing them. The changes to tf-nightly should have been updated to make the changes to this test pass. |
Member
Author
|
This change shouldn't be reverted, see #6128 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #6126.
Confirmed with @u7javed that these changes are no longer needed and is blocking #6128 (https://github.com/tensorflow/tensorboard/actions/runs/3840743814/jobs/6554763016).
Googlers, see internal test at cl/500203241.
#oncall