HParams: Add feature flag to control the rollout of the hparams in time series #6308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesHollyer
approved these changes
Apr 12, 2023
rileyajones
added a commit
that referenced
this pull request
Apr 14, 2023
…msInTimeSeries flag (#6317) Nothing will be displayed until ~#6318~ is merged ## Motivation for features / changes We are working on surfacing hparam data in the time series dashboard. As part of this effort we would like to show the value of hparams in the runs table. The runs table already has partial support for this but it is currently disabled. I am enabling the columns based on the feature flag I added in #6308. Note that you will not see anything in OSS until we fix the call to session_groups ## Technical description of changes I added a new selector to get the feature flag, then modified the metrics_container to read the value of the flag ## Screenshots of UI changes Disabled  Enabled  ## Detailed steps to verify changes work correctly (as executed by you) ## Alternate designs / implementations considered
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
…me series (tensorflow#6308) ## Motivation for features / changes We are about to start working on a new feature to show hparams in the runs table and the scalar card data table and would like to control its roll out. ## Technical description of changes I added a new feature flag. ## Screenshots of UI changes  ## Detailed steps to verify changes work correctly (as executed by you) 1) Start tensorboard 2) Navigate to localhost:6006?showFlags=hparams 3) Ensure the new feature flag is shown in the modal 
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
…msInTimeSeries flag (tensorflow#6317) Nothing will be displayed until ~tensorflow#6318~ is merged ## Motivation for features / changes We are working on surfacing hparam data in the time series dashboard. As part of this effort we would like to show the value of hparams in the runs table. The runs table already has partial support for this but it is currently disabled. I am enabling the columns based on the feature flag I added in tensorflow#6308. Note that you will not see anything in OSS until we fix the call to session_groups ## Technical description of changes I added a new selector to get the feature flag, then modified the metrics_container to read the value of the flag ## Screenshots of UI changes Disabled  Enabled  ## Detailed steps to verify changes work correctly (as executed by you) ## Alternate designs / implementations considered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
We are about to start working on a new feature to show hparams in the runs table and the scalar card data table and would like to control its roll out.
Technical description of changes
I added a new feature flag.
Screenshots of UI changes
Detailed steps to verify changes work correctly (as executed by you)