Bug Fix: Update runs_data_source to request hparams data using FormData #6334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmd3k
approved these changes
Apr 18, 2023
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
…ta (tensorflow#6334) ## Motivation for features / changes The dashboard will not load when `inColab` is true because the runs data cannot be fetched. Googlers see b/278706604 for why this is important ## Technical description of changes When `inColab` is true `POST` requests are automatically converted to `GET` requests see [tensorboard/webapp/webapp_data_source/tb_http_client.ts](https://github.com/tensorflow/tensorboard/blob/master/tensorboard/webapp/webapp_data_source/tb_http_client.ts). This conversion assumes the provided body is of type `FormData`, however, when I open sourced `runs_data_source` in tensorflow#6318 I was unaware of this conversion taking place and didn't modify the format of the post request body. ## Screenshots of UI changes Before:  After:  ## Detailed steps to verify changes work correctly (as executed by you) 1) Start tensorboard 2) Navigate to http://localhost:6006?tensorboardColab#timeseries 3) Assert that the dashboard loads ## Alternate designs / implementations considered I could have updated the conversion happening in [tensorboard/webapp/webapp_data_source/tb_http_client.ts](https://github.com/tensorflow/tensorboard/blob/master/tensorboard/webapp/webapp_data_source/tb_http_client.ts) to accept JSON bodies
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
The dashboard will not load when
inColabis true because the runs data cannot be fetched.Googlers see b/278706604 for why this is important
Technical description of changes
When
inColabis truePOSTrequests are automatically converted toGETrequests see tensorboard/webapp/webapp_data_source/tb_http_client.ts. This conversion assumes the provided body is of typeFormData, however, when I open sourcedruns_data_sourcein #6318 I was unaware of this conversion taking place and didn't modify the format of the post request body.Screenshots of UI changes
Before:
After:
Detailed steps to verify changes work correctly (as executed by you)
Alternate designs / implementations considered
I could have updated the conversion happening in tensorboard/webapp/webapp_data_source/tb_http_client.ts to accept JSON bodies