Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -209,15 +209,17 @@ export class OSSSettingsConverter extends SettingsConverter<
}

if (
backendSettings.hasOwnProperty('singleSelectionHeaders') &&
typeof backendSettings.singleSelectionHeaders === 'object'
Array.isArray(backendSettings.singleSelectionHeaders) &&
// If the settings stored in the backend are invalid, reset back to default.
backendSettings.singleSelectionHeaders[0].name !== undefined
) {
settings.singleSelectionHeaders = backendSettings.singleSelectionHeaders;
}

if (
backendSettings.hasOwnProperty('rangeSelectionHeaders') &&
typeof backendSettings.rangeSelectionHeaders === 'object'
Array.isArray(backendSettings.rangeSelectionHeaders) &&
// If the settings stored in the backend are invalid, reset back to default.
backendSettings.rangeSelectionHeaders[0].name !== undefined
) {
settings.rangeSelectionHeaders = backendSettings.rangeSelectionHeaders;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,48 @@ describe('persistent_settings data_source test', () => {
],
});
});

it('resets singleSelectionEnabled if old ColumnHeader is stored', async () => {
getItemSpy.withArgs(TEST_ONLY.GLOBAL_LOCAL_STORAGE_KEY).and.returnValue(
JSON.stringify({
singleSelectionHeaders: [
{
type: ColumnHeaderType.RUN,
enabled: true,
},
{
type: ColumnHeaderType.VALUE,
enabled: false,
},
],
})
);

const actual = await firstValueFrom(dataSource.getSettings());

expect(actual).toEqual({});
});

it('resets rangeSelectionEnabled if old ColumnHeader is stored', async () => {
getItemSpy.withArgs(TEST_ONLY.GLOBAL_LOCAL_STORAGE_KEY).and.returnValue(
JSON.stringify({
rangeSelectionHeaders: [
{
type: ColumnHeaderType.RUN,
enabled: true,
},
{
type: ColumnHeaderType.MIN_VALUE,
enabled: true,
},
],
})
);

const actual = await firstValueFrom(dataSource.getSettings());

expect(actual).toEqual({});
});
});

describe('#setSettings', () => {
Expand Down