HParam UI: display the displayName #6359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rileyajones
approved these changes
May 3, 2023
Comment on lines
-116
to
-127
| { | ||
| type: ColumnHeaderType.STEP, | ||
| name: 'step', | ||
| displayName: 'Step', | ||
| enabled: true, | ||
| }, | ||
| { | ||
| type: ColumnHeaderType.RELATIVE_TIME, | ||
| name: 'relativeTime', | ||
| displayName: 'Relative', | ||
| enabled: true, | ||
| }, |
Contributor
There was a problem hiding this comment.
Is there a reason you are removing these from the mocks?
Contributor
Author
There was a problem hiding this comment.
No need to test that all of these display the correct text as all it does now is display the displayText. We do not need to test that it displays the displayText that many times.
rileyajones
pushed a commit
to rileyajones/tensorboard
that referenced
this pull request
May 5, 2023
## Motivation for features / changes In tensorflow#6346 we added a displayName attribute to the ColumnHeader. This PR uses that name to be displayed in the headers. ## Technical description of changes I removed lots of headers from a test since now we do not need to test that each type has the proper text displayed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
In #6346 we added a displayName attribute to the ColumnHeader. This PR uses that name to be displayed in the headers.
Technical description of changes
I removed lots of headers from a test since now we do not need to test that each type has the proper text displayed.