Temporarily make new ColumnHeader properties optional for sync #6369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
japie1235813
approved these changes
May 4, 2023
Contributor
japie1235813
left a comment
japie1235813
left a comment
There was a problem hiding this comment.
Generally lgtm but could you make a sync test to see that it passes? thanks
| name: string; | ||
| displayName: string; | ||
| name?: string; // TODO: make required after internal changes are make | ||
| displayName?: string; // TODO: make required after internal changes are make |
Contributor
There was a problem hiding this comment.
nit: Can you add names after TODO?
TODO(jameshollyer): Makes required... made
rileyajones
pushed a commit
to rileyajones/tensorboard
that referenced
this pull request
May 5, 2023
…rflow#6369) ## Motivation for features / changes These new properties break internal sync as the components which use ColumnHeader do not have these properties. I will make them required again once internal uses are changed. Googlers see cl/508442178 for sync test.
JamesHollyer
added a commit
that referenced
this pull request
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
These new properties break internal sync as the components which use ColumnHeader do not have these properties.
I will make them required again once internal uses are changed.
Googlers see cl/508442178 for sync test.