Continue moving to use name in SortingInfo #6400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesHollyer
force-pushed
the
SortingInfoNameRequired
branch
from
d40d6dd to
7babdf9
Compare
rileyajones
approved these changes
May 22, 2023
JamesHollyer
added a commit
that referenced
this pull request
Aug 2, 2023
## Motivation for features / changes This is the final change in a long line of changes to move to using name. The original and functional change is #6362. This had to add name as an optional parameter only in order to avoid internal breakages. Now that we had name we could add the use of name internally(Googlers see cl/534191646) . Then we could switch to make the header optional and the name required which was done here: #6400. After header was optional we removed the use of headers internally(googlers see cl/552643471). Finally in this PR we removed the header attribute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
For the HParam work that is being done we are now using the name field as the unique identifier for columns. Therefore the SortingInfo interface needs to use name and not header. However, making the hard swap to using name would break sync so it is happening in stages. The name switch to using names happened in #6362. However, we had to make name optional for sync reasons. Googlers see cl/534097086 to see where name was added. Now this PR makes header optional. I will then make an internal change to remove it. Then I can finally submit a final PR which removes the property entirely.