Skip to content

Chore: Remove header attribute of sortingInfo interface #6524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JamesHollyer merged 2 commits into from
Aug 2, 2023
Merged

Chore: Remove header attribute of sortingInfo interface #6524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cded7a4
Chore: Remove header attribute of sortingInfo interface
JamesHollyer Aug 1, 2023
96e5c1d
fix tests
JamesHollyer Aug 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion tensorboard/webapp/runs/store/runs_reducers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,6 @@ const {initialState: uiInitialState, reducers: uiNamespaceContextedReducers} =
},
],
sortingInfo: {
header: ColumnHeaderType.RUN,
name: 'run',
order: SortingOrder.DESCENDING,
},
Expand Down
3 changes: 0 additions & 3 deletions tensorboard/webapp/runs/store/runs_reducers_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1624,7 +1624,6 @@ describe('runs_reducers', () => {
{},
{
sortingInfo: {
header: ColumnHeaderType.RUN,
name: 'run',
order: SortingOrder.ASCENDING,
},
Expand All @@ -1634,14 +1633,12 @@ describe('runs_reducers', () => {
state,
actions.runsTableSortingInfoChanged({
sortingInfo: {
header: ColumnHeaderType.HPARAM,
name: 'lr',
order: SortingOrder.DESCENDING,
},
})
);
expect(nextState.ui.sortingInfo).toEqual({
header: ColumnHeaderType.HPARAM,
name: 'lr',
order: SortingOrder.DESCENDING,
});
Expand Down
2 changes: 0 additions & 2 deletions tensorboard/webapp/runs/store/runs_selectors_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,15 +633,13 @@ describe('runs_selectors', () => {
{},
{
sortingInfo: {
header: ColumnHeaderType.RUN,
name: 'run',
order: SortingOrder.ASCENDING,
},
}
)
);
expect(selectors.getRunsTableSortingInfo(state)).toEqual({
header: ColumnHeaderType.RUN,
name: 'run',
order: SortingOrder.ASCENDING,
});
Expand Down
1 change: 0 additions & 1 deletion tensorboard/webapp/runs/store/testing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ export function buildRunsState(
selectionState: new Map(),
runsTableHeaders: [],
sortingInfo: {
header: ColumnHeaderType.RUN,
name: 'run',
order: SortingOrder.DESCENDING,
},
Expand Down
5 changes: 0 additions & 5 deletions tensorboard/webapp/widgets/data_table/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,6 @@ export enum SortingOrder {
}

export interface SortingInfo {
// Currently in the process of moving from header to name.
// Header is no longer used but is required as to not break sync
// TODO(jameshollyer): Remove header once all internal code is switched
// to using name.
header?: ColumnHeaderType;
name: string;
order: SortingOrder;
}
Expand Down