Data Table: enable data table by default #6563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
This feature has been out for awhile and we have had good feedback. However, based on the number we believe many user who would find this useful have not discovered it. This change turns the table on by default.
It is worth noting that if users have enabled/disabled this in the past their choices are stored and then will not see any changes unless they delete their local storage or move to a new computer.
Detailed steps to verify changes work correctly (as executed by you)
I deleted localStorage, reloaded the page, and observed that is was enabled. Then disabled, reloaded the page, and observed that it was still disabled. All is working as expected.