Hparams: Sort by differs then by name.
#6601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmd3k
reviewed
Sep 25, 2023
Contributor
bmd3k
left a comment
bmd3k
left a comment
There was a problem hiding this comment.
We decided offline: Move the "sort by differs (first) and name (second)" logic to the actual code.
yatbear
changed the title
differs then by name.
Member
Author
Done. |
bmd3k
approved these changes
Sep 25, 2023
JamesHollyer
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After sorting with the explicitly specified sorting key (
differs),sorted()returns the order within eachdiffersgroup differently when running externally v.s. internally, which broke internal tests. Changing to sort by name within eachdiffersgroup as a workaround.Googlers, see the test failure details in cl/568227790.
#hparams