Skip to content

Fix copybara import errors #6694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nfelt merged 2 commits into from
Dec 7, 2023
Merged

Fix copybara import errors #6694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46340e1
Renames Filterbar properties to lowerCamelCase
hoonji Dec 7, 2023
fa0c74d
Adds angular chip deps to runs table targets
hoonji Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tensorboard/webapp/runs/views/runs_table/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ tf_ng_module(
"//tensorboard/webapp/alert/actions",
"//tensorboard/webapp/angular:expect_angular_material_button",
"//tensorboard/webapp/angular:expect_angular_material_checkbox",
"//tensorboard/webapp/angular:expect_angular_material_chips",
"//tensorboard/webapp/angular:expect_angular_material_dialog",
"//tensorboard/webapp/angular:expect_angular_material_form_field",
"//tensorboard/webapp/angular:expect_angular_material_icon",
Expand Down Expand Up @@ -145,6 +146,7 @@ tf_ts_library(
"//tensorboard/webapp/angular:expect_angular_cdk_overlay",
"//tensorboard/webapp/angular:expect_angular_core_testing",
"//tensorboard/webapp/angular:expect_angular_material_checkbox",
"//tensorboard/webapp/angular:expect_angular_material_chips",
"//tensorboard/webapp/angular:expect_angular_material_dialog",
"//tensorboard/webapp/angular:expect_angular_material_input",
"//tensorboard/webapp/angular:expect_angular_material_menu",
Expand Down
7 changes: 3 additions & 4 deletions tensorboard/webapp/runs/views/runs_table/filterbar_component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,15 +44,14 @@ export class FilterbarComponent {
@ViewChild('filterModal', {static: false})
private readonly filterModal!: CustomModalComponent;

_selectedFilterName = '';
private internalSelectedFilterName = '';
Copy link
Member Author

@hoonji hoonji Dec 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming is per internal style guide

get selectedFilterName(): string {
return this._selectedFilterName;
return this.internalSelectedFilterName;
}
set selectedFilterName(filterName: string) {
this._selectedFilterName = filterName;
this.internalSelectedFilterName = filterName;
}
// selectedFilter indirectly set using selectedFilterName.
_selectedFilter?: DiscreteFilter | IntervalFilter | undefined;
Copy link
Member Author

@hoonji hoonji Dec 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was unused

get selectedFilter(): DiscreteFilter | IntervalFilter | undefined {
return this.filters.get(this.selectedFilterName);
}
Expand Down