Fixes regression for issue #5548: Avoid attempting to convert dtypes from "mixed precision" policy types. #6859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rileyajones
approved these changes
May 21, 2024
arcra
changed the title
rileyajones
approved these changes
May 21, 2024
Contributor
rileyajones
left a comment
rileyajones
left a comment
There was a problem hiding this comment.
It would be great if we had a test for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following-up on PR #6857, which seems to have introduced a regression for issue #5548.
This change just gracefully degrades the functionality to avoid crashing on an error (as it was before the recent change in #6857), but it might not be a proper fix for the scenario described in that issue.