Updates (vendored) bleach to 6.2.0 and removes dependencies on six and html5lib
#7013
+9
−119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and `html5lib` Addresses tensorflow#7010. The old version of bleach that we were using, needed dependencies `six` and `html5lib` to be installed, and the old version of "six" that we were using for CI via bazel is not supported in python >= 3.12, which causes some issues at least for local builds and CI when using newer versions of python.
|
Oh, is that what you meant? I thought you would provide a separate installation structure to prevent the dependencies you use from conflicting with the old ones. Of course, this is a ridiculous idea, but as long as other libraries do not directly support these dependencies, there is no problem. |
|
By the way, support for 3.9 has been discontinued, so I think you can remove it from the CI/CD file.Older versions are already sufficient. Newer versions should be compatible with new Python standards. Even if they receive security updates, it is unnecessary. In my opinion, providing support for Python 3.10+ is more logical. |
rileyajones
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
Addresses #7010.
The old version of bleach that we were using, needed dependencies
sixandhtml5libto be installed, and the old version of "six" that we were using for CI via bazel is not supported in python >= 3.12, which causes some issues at least for local builds and CI when using newer versions of python.Technical description of changes
Update the version of bleach specified in the
http_archiverule used by bazel and remove rules referring tosixandhtml5lib.Detailed steps to verify changes work correctly (as executed by you)
Created a virtualenv with python 3.12+ and ran
bazel run //tensorboard -- --logdir=<logdir>, and verified that it runs correctly. Also CI should be passing for this to get merged.