Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel incompatible change: Get all tests passing with --incompatible_disable_legacy_cc_provider for Bazel 0.25.0 #26388

Closed
oquenchil opened this issue Mar 6, 2019 · 1 comment
Assignees
Labels
subtype:bazel Bazel related Build_Installation issues type:build/install Build and install issues

Comments

@oquenchil
Copy link

It seems that bazel-watcher will start breaking with the next Bazel release 0.25 because of an incompatible change (bazelbuild/bazel#7036)

It looks like Tensorflow is still using the legacy 'cc' provider for some Starlark rules. I explained in the issue about the steps you can take to migrate to using CcInfo. The same functionality is available with that new provider.

Here's the error:

ERROR: tensorflow/tensorflow/lite/python/optimize/BUILD:28:1: in deps attribute of _py_wrap_cc rule //tensorflow/lite/python/optimize:tensorflow_lite_wrap_calibration_wrapper_py_wrap: '//tensorflow/lite/python/optimize:calibration_wrapper_lib' does not have mandatory providers: 'cc'. Since this rule was created by the macro 'tf_py_wrap_cc', the error might have been caused by the macro implementation in tensorflow/tensorflow/tensorflow.bzl:1743:16
Analyzing [0m target //tensorflow/tools/pip_package:build_pip_package (0 packages\
 loaded, 15887 targets configured)


ERROR: tensorflow/tensorflow/lite/python/optimize/BUILD:28:1: in deps attribute of _py_wrap_cc rule //tensorflow/lite/python/optimize:tensorflow_lite_wrap_calibration_wrapper_py_wrap: '@local_config_python//:python_headers' does not have mandatory providers: 'cc'. Since this rule was created by the macro 'tf_py_wrap_cc', the error might have been caused by the macro implementation in tensorflow/tensorflow/tensorflow.bzl:1743:16
Analyzing:[0m target //tensorflow/tools/pip_package:build_pip_package (0 packages\
 loaded, 15894 targets configured)


ERROR: tensorflow/tensorflow/core/BUILD:2731:1: in deps attribute of _transitive_hdrs rule //tensorflow/core:framework_internal_headers_lib_gather: '//tensorflow/core:lib' does not have mandatory providers: 'cc'. Since this rule was created by the macro 'cc_header_only_library', the error might have been caused by the macro implementation in tensorflow/tensorflow/tensorflow.bzl:1505:54
Analyzing:[0m target //tensorflow/tools/pip_package:build_pip_package (0 packages\
 loaded, 18659 targets configured)


ERROR: tensorflow/tensorflow/core/BUILD:2731:1: in deps attribute of _transitive_hdrs rule //tensorflow/core:framework_internal_headers_lib_gather: '//tensorflow/core:lib_internal' does not have mandatory providers: 'cc'. Since this rule was created by the macro 'cc_header_only_library', the error might have been caused by the macro implementation in tensorflow/tensorflow/tensorflow.bzl:1505:54
Analyzing:[0m target //tensorflow/tools/pip_package:build_pip_package (0 packages\
 loaded, 18662 targets configured)


ERROR: tensorflow/tensorflow/core/BUILD:2731:1: in deps attribute of _transitive_hdrs rule //tensorflow/core:framework_internal_headers_lib_gather: '//tensorflow/core:version_lib' does not have mandatory providers: 'cc'. Since this rule was created by the macro 'cc_header_only_library', the error might have been caused by the macro implementation in tensorflow/tensorflow/tensorflow.bzl:1505:54
Analyzing:[0m target //tensorflow/tools/pip_package:build_pip_package (0 packages\
 loaded, 18665 targets configured)

ERROR: [0mtensorflow/tensorflow/core/BUILD:2731:1: in deps attribute of _transitive_hdrs rule //tensorflow/core:framework_internal_headers_lib_gather: '//tensorflow/core:framework_bounds_check' does not have mandatory providers: 'cc'. Since this rule was created by the macro 'cc_header_only_library', the error might have been caused by the macro implementation in tensorflow/tensorflow/tensorflow.bzl:1505:54
Analyzing:[0m target //tensorflow/tools/pip_package:build_pip_package (0 packages\
 loaded, 18666 targets configured)

ERROR: [0mtensorflow/tensorflow/core/BUILD:2731:1: in deps attribute of _transitive_hdrs rule //tensorflow/core:framework_internal_headers_lib_gather: '//tensorflow/core/platform/default/build_config:platformlib' does not have mandatory providers: 'cc'. Since this rule was created by the macro 'cc_header_only_library', the error might have been caused by the macro implementation in tensorflow/tensorflow/tensorflow.bzl:1505:54
Analyzing:[0m target //tensorflow/tools/pip_package:build_pip_package (0 packages\
 loaded, 18669 targets configured)

ERROR: [0mtensorflow/tensorflow/core/BUILD:2842:1: in deps attribute of _transitive_hdrs rule //tensorflow/core:stream_executor_headers_lib_gather: '//tensorflow/core:stream_executor' does not have mandatory providers: 'cc'. Since this rule was created by the macro 'cc_header_only_library', the error might have been caused by the macro implementation in tensorflow/tensorflow/tensorflow.bzl:1505:54
Analyzing:[0m target //tensorflow/tools/pip_package:build_pip_package (0 packages
@jvishnuvardhan jvishnuvardhan self-assigned this Mar 10, 2019
@jvishnuvardhan jvishnuvardhan added type:build/install Build and install issues subtype:bazel Bazel related Build_Installation issues labels Mar 10, 2019
@jvishnuvardhan jvishnuvardhan added the stat:awaiting tensorflower Status - Awaiting response from tensorflower label Mar 10, 2019
hlopko pushed a commit to bazelbuild/continuous-integration that referenced this issue Mar 29, 2019
@tensorflow-bot
Copy link

tensorflow-bot bot commented Apr 1, 2019

Are you satisfied with the resolution of your issue?
Yes
No

@jvishnuvardhan jvishnuvardhan removed the stat:awaiting tensorflower Status - Awaiting response from tensorflower label Apr 1, 2019
joeleba pushed a commit to joeleba/continuous-integration that referenced this issue Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
subtype:bazel Bazel related Build_Installation issues type:build/install Build and install issues
Projects
None yet
Development

No branches or pull requests

3 participants