Removed trival warnings

[amitsrivastava78]

Removed some warnings from the files

[amitsrivastava78]

@jdduke , thanks for pointing this out, i updated the code as per the review comments, kindly check and approve.

Regards
Amit

[amitsrivastava78]

@jdduke , i have updated the code as per comments, kindly check and update.

Regards
Amit

[amitsrivastava78]

@jdduke , i found one problem in the function CalculateDeallocationOfInternalTensors and CalculateAllocationOfInternalTensors, this is when the node_index becomes negative(in one of the TC) then dues to the implicit conversion with the unsigned int, negative values were becoming positive and hence the test case was passing, not sure this was intentional or oversight, anyway i changed the code as per your suggestion and added the small error check code to ensure sanity.
if (node_index < 0) {
return kTfLiteOk;
}
Hope this is ok, Kindly check and approve.

Regards
Amit

[amitsrivastava78]

@jdduke , i found one problem in the function CalculateDeallocationOfInternalTensors and CalculateAllocationOfInternalTensors, this is when the node_index becomes negative(in one of the TC) then dues to the implicit conversion with the unsigned int, negative values were becoming positive and hence the test case was passing, not sure this was intentional or oversight, anyway i changed the code as per your suggestion and added the small error check code to ensure sanity.
if (node_index < 0) {
return kTfLiteOk;
}
Hope this is ok, Kindly check and approve.

Regards
Amit

[jdduke]

@jdduke , i found one problem in the function CalculateDeallocationOfInternalTensors and CalculateAllocationOfInternalTensors, this is when the node_index becomes negative(in one of the TC)

Interesting, can we expand the test to catch this? Can you tell if this would happen for a legit model/interpreter use-case?

[amitsrivastava78]

@jdduke this happens when the graph is empty , the TC which is triggering this condition is (ArenaPlannerTest, EmptyGraph) , which ultimately calls CalculateAllocations which subtracts one from the active node hence causing the problem.

Regards
Amit

[jdduke]

@jdduke this happens when the graph is empty , the TC which is triggering this condition is (ArenaPlannerTest, EmptyGraph) , which ultimately calls CalculateAllocations which subtracts one from the active node hence causing the problem.

Can you add a (unit) test for this case?

[amitsrivastava78]

@jdduke , thanks for the review i have added one case to cover this scenario, kindly check and approve.

Regards
Amit

[amitsrivastava78]

@jdduke , sorry for the miss,i have updated the code with the comments, explaining why this TC is added and what problem previously was seen. Hope this is ok.

Regards
Amit

[amitsrivastava78]

@jdduke , thanks for approving the PR, can you please help to get this merged.

Regards
Amit

[jdduke]

@rthadur is working to land this.

[amitsrivastava78]

@rthadur is working to land this.

@rthadur any update as to when this can be merged.

Regards
Amit

[amitsrivastava78]

@rthadur , can you please help to get this merged.

Regards
Amit

[rthadur]

Its failing because of internal error . Here is the error:
[==========] Running 14 tests from 1 test suite. [----------] Global test environment set-up. [----------] 14 tests from ArenaPlannerTest [ RUN ] ArenaPlannerTest.EmptyGraph [ OK ] ArenaPlannerTest.EmptyGraph (3 ms) [ RUN ] ArenaPlannerTest.DeallocationOfInputTensor Unhandled exception: @ 0x7feea2d26ce2 GoogleTerminateHandler() @ 0x7feea2814266 __cxxabiv1::__terminate() @ 0x7feea2814293 std::terminate() @ 0x7feea28143cf __cxa_throw @ 0x7feea2758f60 std::__g::__throw_out_of_range_fmt() @ 0x7feea2e33599 tflite::ArenaPlanner::PlanAllocations() @ 0x7feea47cab82 tflite::(anonymous namespace)::ArenaPlannerTest::SetGraph() @ 0x7feea47cba8d tflite::(anonymous namespace)::ArenaPlannerTest_DeallocationOfInputTensor_Test::TestBody() @ 0x7feea35f960a testing::Test::Run() @ 0x7feea35fa973 testing::TestInfo::Run() @ 0x7feea35fb50b testing::TestSuite::Run() @ 0x7feea360ba77 testing::internal::UnitTestImpl::RunAllTests() @ 0x7feea360b446 testing::UnitTest::Run() @ 0x7feea47c9701 main @ 0x7feea23aabbd __libc_start_main @ 0x55574cb9e4c9 ../sysdeps/x86_64/start.S:108 _start terminate called after throwing an instance of 'std::__g::out_of_range'

[amitsrivastava78]

@rthadur , i have fixed the problem.
@jdduke , i know this is old PR, can you please re approve.

Regards
Amit

[rthadur]

Changes are merged internally , waiting for auto merge to happen.