Skip to content

Add complex64 and complex128 gpu support for tensor_scatter_nd_add #40585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

yongtang
Copy link
Member

This PR adds complex64 and complex128 gpu support for tensor_scatter_nd_add,
as was raised in #40577.

This PR fixes #40577.

Signed-off-by: Yong Tang yong.tang.github@outlook.com

This PR adds complex64 and complex128 gpu support for tensor_scatter_nd_add,
as was raised in 40577.

This PR fixes 40577.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Jun 18, 2020
@gbaned gbaned self-assigned this Jun 18, 2020
@gbaned gbaned added the prtype:bugfix PR to fix a bug label Jun 18, 2020
@gbaned gbaned requested a review from chsigg June 18, 2020 17:16
@gbaned gbaned added the awaiting review Pull request awaiting review label Jun 23, 2020
Copy link
Contributor

@jaingaurav jaingaurav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a test case that covers this already?

@gbaned gbaned added the comp:core issues related to core part of tensorflow label Jul 3, 2020
@tensorflowbutler tensorflowbutler removed the awaiting review Pull request awaiting review label Jul 5, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jul 6, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jul 6, 2020
@tensorflow-copybara tensorflow-copybara merged commit 014cdf6 into tensorflow:master Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:core issues related to core part of tensorflow prtype:bugfix PR to fix a bug ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tensor scatter nd add doesn't support complex64 in tf 2.3-dev
7 participants