This repository has been archived by the owner on Oct 17, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 95
Add layer: tf.layers.dot #330
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
555fb9a
WIP
caisq 6a4f326
WIP
caisq 46c30e6
WIP2
caisq 2950846
Add tensor-based tests
caisq a85fba4
Cleanups
caisq 0e56f2a
Throw NotImplementedError from computeMask()
caisq cbccd01
Merge branch 'master' into merge-dot
caisq f34445c
Add guard for tensor inputs of 4+D for Dot
caisq 1d3403d
Respond to reviewer comments
caisq 5fcf292
Call registerClass()
caisq 4aad01f
Fix incorrect className
caisq 81a9290
Rename private helper method
caisq d79104f
Simplify type signature
caisq File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, it seems possible that this results in an infinite loop if the user tries to dot product a scalar. Can we throw an error message instead?