This repository has been archived by the owner on Sep 17, 2022. It is now read-only.
Upgrade 0.3.x to 0.15.3 #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsthorat
approved these changes
Feb 25, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 2 of 2 files at r2.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @dsmilkov, @nsthorat, and @pyu10055)
nkreeger
added a commit
that referenced
this pull request
Mar 12, 2019
* 0.3.x: Update the publish-npm script to allow publishing from the release branch. (#203) DEV * Upgrade 0.3.x to 0.15.3 (#210) <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/tensorflow/tfjs-node/210) <!-- Reviewable:end --> * Fix win GPU packaging. (#208) (#211) Turns out that the windows GPU builds for TensorFlow 1.12 lack the directory structure and eager headers. A bug has been filed with core TF - but we should bake in some fixes for this. This PR simply refactors the downloading logic to a new file. I'd like to use this logic in the node-gles package as well (maybe worth releasing as a stand-alone package in the future). After the refactoring, I check the directory structure in Windows. If the folder structure is missing, but the required tensorflow.dll exists - I re-create the directory structure, move and download the proper header files. The screenshot below shows the contents of TF 1.12 Windows GPU:  <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/tensorflow/tfjs-node/208) <!-- Reviewable:end --> * Bump 0.3.1 * Add TensorBoard callback for model training: tf.node.tensorBoard() (#202) (#213) FEATURE See example screenshot:  Fixes tensorflow/tfjs#686 * [0.3.x] Upgrade nyc package fo fix lodash security issue. (#218) (#219) Bump for 0.3.x so we can get a security release spun. https://github.com/tensorflow/tfjs-node/network/alert/yarn.lock/lodash/open <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/tensorflow/tfjs-node/219) <!-- Reviewable:end --> * Bump to 0.3.2 * Upgrade TS libraries and change binding from typings file to plain TypeScript definition. * Upgrade TS dependencies * save * Fix deps-stage * save * Revert TS changes and keep binary staging fixes.
nkreeger
added a commit
that referenced
this pull request
Mar 13, 2019
* 0.3.x: Update the publish-npm script to allow publishing from the release branch. (#203) DEV * Upgrade 0.3.x to 0.15.3 (#210) <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/tensorflow/tfjs-node/210) <!-- Reviewable:end --> * Fix win GPU packaging. (#208) (#211) Turns out that the windows GPU builds for TensorFlow 1.12 lack the directory structure and eager headers. A bug has been filed with core TF - but we should bake in some fixes for this. This PR simply refactors the downloading logic to a new file. I'd like to use this logic in the node-gles package as well (maybe worth releasing as a stand-alone package in the future). After the refactoring, I check the directory structure in Windows. If the folder structure is missing, but the required tensorflow.dll exists - I re-create the directory structure, move and download the proper header files. The screenshot below shows the contents of TF 1.12 Windows GPU:  <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/tensorflow/tfjs-node/208) <!-- Reviewable:end --> * Bump 0.3.1 * Add TensorBoard callback for model training: tf.node.tensorBoard() (#202) (#213) FEATURE See example screenshot:  Fixes tensorflow/tfjs#686 * [0.3.x] Upgrade nyc package fo fix lodash security issue. (#218) (#219) Bump for 0.3.x so we can get a security release spun. https://github.com/tensorflow/tfjs-node/network/alert/yarn.lock/lodash/open <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/tensorflow/tfjs-node/219) <!-- Reviewable:end --> * Bump to 0.3.2 * Upgrade TS libraries and change binding from typings file to plain TypeScript definition. * Upgrade TS dependencies * save * Fix deps-stage * save * Revert TS changes and keep binary staging fixes. * Don't use a definition file for the bindings. This causes many issues and doesn't help with redistribution. It looks like exporting a local definition file on top of what else is exported is not a common supported TypeScript use case. This fix simply moves defnitions into a normal TypeScript file. This should fix: tensorflow/tfjs#1092 * save * Add typescript integration project. * save * Add license
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is