Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presubmit change detection is wrong for non-Bazel packages #6384

Closed
mattsoulanille opened this issue May 9, 2022 · 1 comment · Fixed by #6390
Closed

Presubmit change detection is wrong for non-Bazel packages #6384

mattsoulanille opened this issue May 9, 2022 · 1 comment · Fixed by #6390
Assignees
Labels
type:bug Something isn't working

Comments

@mattsoulanille
Copy link
Member

Please make sure that this is a bug. As per our
GitHub Policy,
we only address code/doc bugs, performance issues, feature requests and
build/installation issues on GitHub. tag:bug_template

System information
The continuous integration docker image running presubmits.

Describe the current behavior
Presubmits for packages that do not build with Bazel are skipped when only Bazel dependencies change. This is because Bazel packages are not considered dependencies by package_dependencies.json.

Describe the expected behavior
Presubmits run on a package when its dependencies (including transitive dependencies) change.

Standalone code to reproduce the issue
#6329 did not test tfjs-backend-wasm (or any other non-Bazel packages) even though it changed tfjs-core.

Other info / logs Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached.

Cloudbuild logs for 6329

@mattsoulanille mattsoulanille added the type:bug Something isn't working label May 9, 2022
@mattsoulanille mattsoulanille self-assigned this May 9, 2022
mattsoulanille added a commit that referenced this issue May 10, 2022
Fix incorrect presubmit change detection between Bazel and non-Bazel packages.
Fixes #6384
@google-ml-butler
Copy link

Are you satisfied with the resolution of your issue?
Yes
No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant