Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verdaccio tests fail if the current version is published to npm #7557

Open
mattsoulanille opened this issue Apr 6, 2023 · 1 comment · May be fixed by #7699
Open

Verdaccio tests fail if the current version is published to npm #7557

mattsoulanille opened this issue Apr 6, 2023 · 1 comment · May be fixed by #7699
Assignees
@mattsoulanille
Labels
comp:core Merge : Status Pending type:bug Something isn't working

Comments

@mattsoulanille
Copy link
Member

mattsoulanille commented Apr 6, 2023 •
edited
Loading

Verdaccio tests try to publish TFJS to a local verdaccio repository (which simulates npm). This repository is currently configured to look at npmjs as an upstream. This is fine until we try to publish a version of TFJS to verdaccio that is already published to npm. We do this when creating a PR to update the lockfiles of the release branch after publishing that branch to NPM. e.g. #7556

The current workaround is to edit the verdaccio config to not forward @tensorflow scoped packages to npmjs in the lockfiles PR. This shouldn't be set permanently because then we wouldn't be able to build and publish downstream packages (e.g. @tensorflow/tfjs) in the release script if we hadn't already built the upstream packages (e.g. @tensorflow/tfjs-core). When building the downstream package, we would look for the upstream package in verdaccio, and since it's not configured to forward to npmjs, it wouldn't find the package, causing an npm install error.
@mattsoulanille mattsoulanille added the type:bug Something isn't working label Apr 6, 2023
@mattsoulanille mattsoulanille self-assigned this Apr 6, 2023
mattsoulanille added a commit that referenced this issue Apr 7, 2023
@mattsoulanille
Remove npm proxy for @tensorflow scoped packages
088d045 
See #7557
@mattsoulanille mattsoulanille changed the title Verdaccio tests fail if the version is published to npm Verdaccio tests fail if the current version is published to npm Apr 7, 2023
chunnienc pushed a commit that referenced this issue Apr 7, 2023
@mattsoulanille
Update lockfiles branch tfjs_4.4.0_lockfiles lock files. (#7556)
5cc0c77 
* Update lockfiles branch tfjs_4.4.0_lockfiles lock files.

* Remove npm proxy for @tensorflow scoped packages

See #7557
@pyu10055
Copy link
Collaborator

pyu10055 commented Apr 7, 2023

@mattsoulanille Is it possible to detect the release test and avoid forwarding conditionally?

mattsoulanille added a commit that referenced this issue May 5, 2023
@mattsoulanille
Remove npm proxy for @tensorflow scoped packages
740d444 
See #7557
mattsoulanille added a commit that referenced this issue May 5, 2023
@mattsoulanille
Update tfjs_4.5.0 lockfiles (#7659)
e132574 
* Update lockfiles branch tfjs_4.5.0_lockfiles lock files.

* Remove npm proxy for @tensorflow scoped packages

See #7557
mattsoulanille added a commit that referenced this issue May 17, 2023
@mattsoulanille
Remove npm proxy for @tensorflow scoped packages
6a6cf01 
See #7557
mattsoulanille added a commit that referenced this issue May 17, 2023
@mattsoulanille
Remove npm proxy for @tensorflow scoped packages
f6b5e13 
See #7557
mattsoulanille added a commit to mattsoulanille/tfjs that referenced this issue May 17, 2023
@mattsoulanille
Disable verdaccio tfjs package forwarding when updating lockfiles
b1494d8 
Disable verdaccio npm forwarding for tfjs packages when updating lockfiles.
See tensorflow#7557 for details.

Fixes tensorflow#7557
@mattsoulanille mattsoulanille linked a pull request May 17, 2023 that will close this issue
Open
mattsoulanille added a commit that referenced this issue May 17, 2023
@mattsoulanille
Update tfjs_4.6.0_lockfiles (#7698)
96700f1 
* Update tfjs_4.6.0_lockfiles

* Remove npm proxy for @tensorflow scoped packages

See #7557
mattsoulanille added a commit that referenced this issue Jun 6, 2023
@mattsoulanille
Remove npm proxy for @tensorflow scoped packages
615c9fc 
See #7557
mattsoulanille added a commit that referenced this issue Jun 6, 2023
@Dedongala @mattsoulanille
Update lockfiles branch tfjs_4.7.0_lockfiles lock files. (#7741)
7f928a1 
* Update lockfiles branch tfjs_4.7.0_lockfiles lock files.

* Remove npm proxy for @tensorflow scoped packages

See #7557

---------

Co-authored-by: Matthew Soulanille <msoulanille@google.com>
Dedongala pushed a commit that referenced this issue Jun 21, 2023
@mattsoulanille @Dedongala
Remove npm proxy for @tensorflow scoped packages
7e96131 
See #7557
mattsoulanille added a commit that referenced this issue Jun 21, 2023
@Dedongala @mattsoulanille
Remove npm proxy for @tensorflow scoped packages (#7771)
e3c2a03 
See #7557

Co-authored-by: Matthew Soulanille <msoulanille@google.com>
Dedongala added a commit that referenced this issue Jun 21, 2023
@Dedongala @mattsoulanille
Update lockfiles branch tfjs_4.8.0_lockfiles lock files. (#7769)
74081cb 
* Update lockfiles branch tfjs_4.8.0_lockfiles lock files.

* Remove npm proxy for @tensorflow scoped packages (#7771)

See #7557

Co-authored-by: Matthew Soulanille <msoulanille@google.com>

---------

Co-authored-by: Matthew Soulanille <msoulanille@google.com>
Dedongala pushed a commit that referenced this issue Jul 18, 2023
@mattsoulanille @Dedongala
Remove npm proxy for @tensorflow scoped packages
74ccb0d 
See #7557
Dedongala pushed a commit that referenced this issue Jul 18, 2023
@mattsoulanille @Dedongala
Remove npm proxy for @tensorflow scoped packages
6bcb918 
See #7557
Dedongala pushed a commit that referenced this issue Jul 18, 2023
@mattsoulanille @Dedongala
Remove npm proxy for @tensorflow scoped packages
b16ff18 
See #7557
Dedongala added a commit that referenced this issue Jul 18, 2023
@Dedongala @pforderique
@Linchenn @mattsoulanille
Patchbranch2 (#7856)
ac49291 
* [gpt2pre 3] Preprocessor Layer (#7794)

* Add Preprocessor layer

* Remove uneeded args

* Use LayerArgs

* Remove import from src

* Add fromConfig method

* Serialize tokenizer properly

* Add test cases for preprocessor

* Preprocessor tests with no set tokenizer

---------

Co-authored-by: Linchenn <40653845+Linchenn@users.noreply.github.com>

* Remove npm proxy for @tensorflow scoped packages

See #7557

---------

Co-authored-by: Piero F Orderique <45519489+pforderique@users.noreply.github.com>
Co-authored-by: Linchenn <40653845+Linchenn@users.noreply.github.com>
Co-authored-by: Matthew Soulanille <msoulanille@google.com>
mattsoulanille added a commit that referenced this issue Jul 19, 2023
@mattsoulanille
Remove npm proxy for @tensorflow scoped packages
e0025b3 
See #7557
Dedongala added a commit that referenced this issue Jul 19, 2023
@Dedongala @mattsoulanille
Update lockfiles branch tfjs_4.9.0_lockfiles lock files. (#7855)
f967fab 
* Update lockfiles branch tfjs_4.9.0_lockfiles lock files.

* Remove npm proxy for @tensorflow scoped packages

See #7557

---------

Co-authored-by: Matthew Soulanille <msoulanille@google.com>
mattsoulanille added a commit that referenced this issue Aug 1, 2023
@mattsoulanille
Remove npm proxy for @tensorflow scoped packages
1ae3af1 
See #7557
Dedongala added a commit that referenced this issue Aug 1, 2023
@Dedongala @mattsoulanille
Update lockfiles branch tfjs_4.10.0_lockfiles lock files. (#7886)
99f9935 
* Update lockfiles branch tfjs_4.10.0_lockfiles lock files.

* Remove npm proxy for @tensorflow scoped packages

See #7557

---------

Co-authored-by: Matthew Soulanille <msoulanille@google.com>
mattsoulanille added a commit that referenced this issue Oct 13, 2023
@mattsoulanille
Remove npm proxy for @tensorflow scoped packages
62ee42c 
See #7557
pyu10055 pushed a commit that referenced this issue Oct 13, 2023
@mattsoulanille
Update lockfiles branch tfjs_4.12.0-rc.0_lockfiles lock files. (#8002)
b493c88 
INTERNAL
INTERNAL
* Update lockfiles branch tfjs_4.12.0-rc.0_lockfiles lock files.

* Remove npm proxy for @tensorflow scoped packages

See #7557
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattsoulanille mattsoulanille

Labels
comp:core Merge : Status Pending type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable verdaccio tfjs package forwarding when updating lockfiles mattsoulanille/tfjs
3 participants
@pyu10055 @mattsoulanille @gaikwadrahul8