Lint Bazel packages with a central lint script

[mattsoulanille]

Lint Bazel-built packages with a central yarn lint script at the root of the repository. This change also removes several cloudbuild files that are currently only used for linting.

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.

---

This change is 

[pyu10055]

Reviewable status: 0 of 1 approvals obtained (waiting on @mattsoulanille)

---

BAZEL_MIGRATION.md, line 407 at r2 (raw file):

### Move linting to the repo-wide lint script
#### Add the new Bazel package to the [repo-wide tslint tsconfig](tsconfig_tslint.json):

how about the tsconfig.json file at the root directory, will that need to be updated?

---

scripts/package_dependencies.json, line 3 at r2 (raw file):

{
  "tfjs-automl": [],
  "tfjs-converter": [],

why the deps config needs to be updated?

---

tfjs-core/src/log.ts, line 18 at r2 (raw file):

 */

// tslint:disable-next-line:no-circular-imports

this is fixed by Jing here #5783, maybe you can try to sync again.

[mattsoulanille]

Reviewable status: 0 of 1 approvals obtained (waiting on @pyu10055)

---

BAZEL_MIGRATION.md, line 407 at r2 (raw file):

Previously, pyu10055 (Ping Yu) wrote…

how about the tsconfig.json file at the root directory, will that need to be updated?

The normal tsconfig.json file does not need to be updated when tsconfig_tslint.json is updated. The tsconfig_tslint.json file is only used by tslint. It tells tslint the project structure that is contained in the Bazel BUILD files so it can correctly check rules that depend on types across our packages (we do this differently in google3, but I think it would be difficult to dreplicate).

---

scripts/package_dependencies.json, line 3 at r2 (raw file):

Previously, pyu10055 (Ping Yu) wrote…

why the deps config needs to be updated?

I removed several cloudbuild.yml files from packages that were only running lint scripts. With this change, those packages are linted by the global lint script, so they had no more cloudbuild steps to run. package_dependencies.json exists only to track dependencies for the for the cloudbuild generator script, so those packages that no longer have a cloudbuild.yml file should be removed from it.

---

tfjs-core/src/log.ts, line 18 at r2 (raw file):

Previously, pyu10055 (Ping Yu) wrote…

this is fixed by Jing here #5783, maybe you can try to sync again.

Thanks! There seems to be another one caused by #5784. base_side_effects.ts <-> platform_node.ts. I removed it and the tests still pass.