Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webgl]Remove unnecessary blocking GPU call. #5795

Merged
merged 1 commit into from
Oct 29, 2021
Merged

[webgl]Remove unnecessary blocking GPU call. #5795

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions tfjs-backend-webgl/src/backend_webgl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,11 +307,16 @@ export class MathBackendWebGL extends KernelBackend {
return this.convertAndCacheOnCPU(dataId);
}

if (!env().getBool('WEBGL_DOWNLOAD_FLOAT_ENABLED') &&
if (env().getBool('DEBUG')) {
// getBool('WEBGL_DOWNLOAD_FLOAT_ENABLED') caused a blocking GPU call.
// For performance reason, only check it for debugging. In production,
// it doesn't handle this use case anyway, so behavior is not changed.
if (!env().getBool('WEBGL_DOWNLOAD_FLOAT_ENABLED') &&
env().getNumber('WEBGL_VERSION') === 2) {
throw new Error(
`tensor.data() with WEBGL_DOWNLOAD_FLOAT_ENABLED=false and ` +
`WEBGL_VERSION=2 not yet supported.`);
throw new Error(
`tensor.data() with WEBGL_DOWNLOAD_FLOAT_ENABLED=false and ` +
`WEBGL_VERSION=2 not yet supported.`);
}
}

let buffer: WebGLBuffer = null;
Expand Down