Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webgl: Support uniforms for pack/unpack programs #5835

Merged
merged 3 commits into from
Nov 23, 2021
Merged

webgl: Support uniforms for pack/unpack programs #5835

merged 3 commits into from
Nov 23, 2021

Conversation

qjia7
Copy link
Contributor

@qjia7 qjia7 commented Nov 12, 2021 •
edited
Loading

BUG: #5205

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.

This change is Reviewable

@google-cla google-cla bot added the cla: yes label Nov 12, 2021
@qjia7 qjia7 requested review from lina128 and pyu10055 November 12, 2021 08:06
lina128
lina128 approved these changes Nov 12, 2021
View reviewed changes
Copy link
Collaborator

@lina128 lina128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Jiajia! LGTM

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @pyu10055)

lina128
lina128 reviewed Nov 12, 2021
View reviewed changes
Copy link
Collaborator

@lina128 lina128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jiajia, how do you test the change?

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @pyu10055)

@lina128 lina128 self-requested a review November 12, 2021 19:48
qjia7
qjia7 commented Nov 13, 2021
View reviewed changes
Copy link
Contributor Author

@qjia7 qjia7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Firstly, I will make sure all yarn test are pass enabling/disabling WEBGL_USE_SHAPES_UNIFORMS.
Secondly, I tested mesh_128 model in benchmarks, which includes 5 PackProgram binarys and 5 UnpackProgram binarys in binaryCache in backend_webgl.ts when enable WEBGL_USE_SHAPES_UNIFORMS. With this PR, only 1 PackProgram binary and 1 UnpackProgram binary are left.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @lina128 and @pyu10055)

pyu10055
pyu10055 approved these changes Nov 16, 2021
View reviewed changes
Copy link
Collaborator

@pyu10055 pyu10055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 2 of 1 approvals obtained (waiting on @lina128)

@qjia7
Copy link
Contributor Author

qjia7 commented Nov 23, 2021

Please help merge it if no more comments.

@lina128 lina128 merged commit 432708a into tensorflow:master Nov 23, 2021
@qjia7 qjia7 deleted the pack_unpack branch November 25, 2021 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyu10055 pyu10055 pyu10055 approved these changes

@lina128 lina128 Awaiting requested review from lina128

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qjia7 @pyu10055 @lina128