Add doccomment for fromPixels inconsistent result. #5865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyu10055
requested changes
Nov 18, 2021
There was a problem hiding this comment.
Reviewable status: 0 of 1 approvals obtained (waiting on @lina128)
tfjs-core/src/ops/browser.ts, line 56 at r1 (raw file):
* @returns A Tensor3D with the shape `[height, width, numChannels]`. * * Note: fromPixels can be lossy in some cases, image may result in slightly
same image
tfjs-core/src/ops/browser.ts, line 57 at r1 (raw file):
* * Note: fromPixels can be lossy in some cases, image may result in slightly * different tensor values, if rendered with different rendering engines.
rendering by
pyu10055
approved these changes
Nov 18, 2021
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @lina128)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5482
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is