Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update isnan implementation in WebGL backend to follow IEEE 754-1985 #6107

Merged
merged 3 commits into from
Feb 17, 2022
Merged

Update isnan implementation in WebGL backend to follow IEEE 754-1985 #6107

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39a4002
Update isnan implementation in WebGL backend to follow IEEE 754-1985
shaoboyan Feb 9, 2022
51a80ee
Only apply bit version isnan for WebGL2
shaoboyan Feb 10, 2022
12ed9d5
Fix 80-line exceeed issue
shaoboyan Feb 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions tfjs-backend-webgl/src/glsl_version.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,19 @@ export function getGlslDifferences(): GLSL {
// Use custom isnan definition to work across differences between
// implementations on various platforms. While this should happen in ANGLE
// we still see differences between android and windows (on chrome) when
// using isnan directly.
// using isnan directly. Since WebGL2 supports uint type and
// floatBitsToUinT built-in function, we could implment isnan following
// IEEE 754 rules.
// NaN defination in IEEE 754-1985 is :
// - sign = either 0 or 1.
// - biased exponent = all 1 bits.
// - fraction = anything except all 0 bits (since all 0 bits represents
// infinity).
// https://en.wikipedia.org/wiki/IEEE_754-1985#Representation_of_non-numbers
defineSpecialNaN = `
bool isnan_custom(float val) {
return (val > 0.0 || val < 0.0) ? false : val != 0.0;
uint floatToUint = floatBitsToUint(val);
return (floatToUint & 0x7fffffffu) > 0x7f800000u;
}

bvec4 isnan_custom(vec4 val) {
Expand Down