Webgpu gather zero #6166
Merged
Webgpu gather zero #6166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qjia7
reviewed
Feb 21, 2022
| const userCode = ` | ||
| ${getMainHeaderAndGlobalIndexString()} | ||
| if (index < uniforms.size) { | ||
| let resRC = getCoordsFromIndex(index); | ||
| setOutputAtIndex(index, getA(${sourceCoords})); | ||
| let indexZ = i32(getIndices(resRC.x, resRC.z)); | ||
| let inBounds = select(0.0, 1.0, indexZ >= 0 && indexZ < ${this.aShape[2]}); |
There was a problem hiding this comment.
Can you directly use indexZ < aShape[2] instead of indexZ < ${this.aShape[2]}? I think aShape is already a uniform value. In this case, you don't need to change the shaderKey.
haoyunfeix
force-pushed
the
webgpu_gather_zero
branch
from
72d5f05 to
8bae974
Compare
|
@lina128 @mattsoulanille Do you think this is appropriate to move case to core test gather_test.ts? https://github.com/tensorflow/tfjs/pull/6166/files#diff-d04767f708ca30f31465a8848e7175c5646384caa1940f0cd68543953a7038d8 |
lina128
approved these changes
Mar 18, 2022
There was a problem hiding this comment.
LGTM
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @qjia7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is