[wasm] Fix threaded worker blob syntax error #6214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JS's Blob replaces "\n" with a newline character. In the threaded worker bundle, there's a "\n" in `if(ENVIRONMENT_IS_NODE){fs.writeSync(2,text+"\n")`. When it is replaced with a newline, it splits a string across multiple lines, which is not valid JavaScript.
This change prevents Blob from doing that replacement by escaping the "\n" character as "\\n".
fixes tensorflow#6203
jinjingforever
approved these changes
Mar 10, 2022
pyu10055
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JS's
Blobreplaces "\n" with a newline character. In the threaded worker bundle, there's a "\n" inif(ENVIRONMENT_IS_NODE){fs.writeSync(2,text+"\n"). When it is replaced with a newline, it splits a string across multiple lines, which is not valid JavaScript.This change prevents Blob from doing that replacement by escaping the "\n" character as "\n".
fixes #6203
This was not caught by presubmits because they do not run threaded tests. I'll fix this in another PR.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is