-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TensorListLength op #6282
Add TensorListLength op #6282
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thank you Lin!
Please always provide meaningful CL description that helps the reviewers (ie links to TF op definition and TF op document).
Reviewable status: 0 of 1 approvals obtained (waiting on @Linchenn)
tfjs-converter/src/operations/executors/control_executor_test.ts, line 1010 at r1 (raw file):
expect(size.length).toEqual(1); expect(size[0].shape).toEqual([]); test_util.expectArraysClose(size[0].dataSync(), new Int32Array([2]));
you can use a simple array [2]
directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the description. Thank you Ping!
Reviewable status: 0 of 1 approvals obtained (waiting on @pyu10055)
tfjs-converter/src/operations/executors/control_executor_test.ts, line 1010 at r1 (raw file):
Previously, pyu10055 (Ping Yu) wrote…
you can use a simple array
[2]
directly.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 5 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @Linchenn)
tfjs-converter/src/operations/executors/control_executor_test.ts, line 1010 at r1 (raw file):
Previously, Linchenn wrote…
Done.
will the following work?
test_util.expectArraysClose(size[0].dataSync(), [2]);
Code quote:
test_util.expectArraysClose(size[0].dataSync(), new Array([2]));
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @pyu10055)
tfjs-converter/src/operations/executors/control_executor_test.ts, line 1010 at r1 (raw file):
Previously, pyu10055 (Ping Yu) wrote…
will the following work?
test_util.expectArraysClose(size[0].dataSync(), [2]);
Done. Thank you!
Add
TensorListLength
op, as mentioned in Issue.Here is the corresponding TensorListLength op in TensorFlow:
https://www.tensorflow.org/api_docs/python/tf/raw_ops/TensorListLength?hl=vi
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is