Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[converter] Add missing cpu dependency to test_snippets #6416

Merged

Conversation

mattsoulanille
Copy link
Member

@mattsoulanille mattsoulanille commented May 17, 2022

Add missing Bazel dependency on //tfjs-backend-cpu/src:tfjs-backend-cpu_lib to tfjs-converter/scripts/test_snippets.ts, which imports tfjs-backend-cpu.

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

Add missing Bazel dependency on //tfjs-backend-cpu/src:tfjs-backend-cpu_lib to tfjs-converter/scripts/test_snippets.ts, which imports tfjs-backend-cpu.
@mattsoulanille mattsoulanille force-pushed the converter_test_snippets_fix branch from 6f7463d to a95632f Compare May 17, 2022 20:49
Copy link
Collaborator

@pyu10055 pyu10055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 2 of 1 approvals obtained (waiting on @ahmedsabie)

@pyu10055 pyu10055 merged commit a55b553 into tensorflow:master May 18, 2022
@mattsoulanille mattsoulanille deleted the converter_test_snippets_fix branch May 18, 2022 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants