Remove python2 from tfjs-converter #6575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyu10055
approved these changes
Jun 28, 2022
There was a problem hiding this comment.
Thanks Matt for finally removing the python2 deps.
One thing to notice, the main reason we used PyEnquirer for interactive CLI is due to its python 2 support. As we removing python 2 deps, we can move to an newer version, that will resolve some of other older deps.
questionary is the newer compatible version, we can tackle that in a future PR.
https://github.com/tmbo/questionary
Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained
Linchenn
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove python2 from tfjs-converter and publish only a python3 wheel. Remove the custom Python Bazel toolchain that builds Python from source and replace it with the rules_python toolchain that downloads pre-built python3 binaries.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is