-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Converter] Script for building the map #7732
Conversation
Draft a script for build map of TFJS class and TF module path.
cea6001
to
e8eeb4c
Compare
5d17e5e
to
3b7e611
Compare
382a5bf
to
4751e92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may also do the tests for TFCLASS_MODULE_MAP.
tfjs-converter/python/tensorflowjs/converters/build_module_map.py
Outdated
Show resolved
Hide resolved
tfjs-converter/python/tensorflowjs/converters/build_module_map.py
Outdated
Show resolved
Hide resolved
tfjs-converter/python/tensorflowjs/converters/build_module_map.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just some nits. Thanks!
elif inspect.ismodule(obj): | ||
_build_class_module_map(obj) | ||
|
||
def build_map(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get_module_path and others could call _build_class_module_map directly
@@ -0,0 +1,55 @@ | |||
# Copyright 2018 Google LLC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could update to 2023.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Draft a script for build map of TFJS class and TF module path.
Mapping examples:
'GaussianDropout': 'keras.layers',
'AlphaDropout': 'keras.layers',
'Dropout': 'keras.layers',
'SpatialDropout1D': 'keras.layers',
'Dense': 'keras.layers'
By using this script, we can find the corresponding module path in TF. This is part of changes needed for supporting keras V3 format.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.